From 7c563b1a710e32ab0036d0cadfa2fb8fb93cfbb4 Mon Sep 17 00:00:00 2001 From: Guillume DIDIER Date: Mon, 19 Jul 2021 10:53:46 +0200 Subject: [PATCH] The core per socket logic is not robust to padding Added some fixmes --- cache_utils/src/lib.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cache_utils/src/lib.rs b/cache_utils/src/lib.rs index f6b422b..de5e86f 100644 --- a/cache_utils/src/lib.rs +++ b/cache_utils/src/lib.rs @@ -52,6 +52,7 @@ pub fn noop(_: *const T) {} #[cfg(feature = "use_std")] pub fn find_core_per_socket() -> u8 { + // FIXME error handling use std::process::Command; use std::str::from_utf8; @@ -66,7 +67,7 @@ pub fn find_core_per_socket() -> u8 { //println!("Number of cores per socket: {}", cps_str); - let core_per_socket: u8 = core_per_socket_str[0..(core_per_socket_str.len() - 1)] + let core_per_socket: u8 = core_per_socket_str[0..(core_per_socket_str.len() - 1)] // FIXME, for cases such as ' 24 ' .parse() .unwrap_or(0); core_per_socket